Skip to content

Conversation

@dbu
Copy link
Contributor

@dbu dbu commented Aug 19, 2014

fix #141

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added "In addition" to make it clear that this is something different.

@dbu
Copy link
Contributor Author

dbu commented Aug 19, 2014

@ddeboer any idea why the build is failing with "Resources/doc/features/invalidation.rst:19: WARNING: undefined label: foshttpcache:invalidation-introduction (if the link has no caption the label must precede a section header)"? i do exactly the same thing as there is 3 lines above about proxy-configuration.

@ddeboer
Copy link
Member

ddeboer commented Aug 19, 2014

I think the ref should be invalidation introduction (without dash): https://raw.githubusercontent.com/FriendsOfSymfony/FOSHttpCache/master/doc/invalidation-introduction.rst (at the top).

@dbu
Copy link
Contributor Author

dbu commented Aug 19, 2014

I think the ref should be |invalidation introduction| (without underscore).

i used a hyphen, not an underscore. i looked at the proxy-configuration
3 lines above which works. removing the hyphen as you say indeed creates
me a link that works - no idea why. but well, i think we can merge now.

@ddeboer
Copy link
Member

ddeboer commented Aug 19, 2014

That’s because the ref is there called proxy-configuration (with dash): https://raw.githubusercontent.com/FriendsOfSymfony/FOSHttpCache/master/doc/proxy-configuration.rst. Not very consistent, I realise. 😉

Anyway, as long as this builds, we’re good to go.

@dbu
Copy link
Contributor Author

dbu commented Aug 19, 2014

aaahh. and i thought we can reference a file. well ok, now it all makes
sense :-)

@ddeboer
Copy link
Member

ddeboer commented Aug 19, 2014

Good to hear. :)

dbu added a commit that referenced this pull request Aug 19, 2014
warn about validation vs invalidation and cleanup feature list
@dbu dbu merged commit f8a1c19 into master Aug 19, 2014
@dbu dbu deleted the invalidation-vs-validation branch August 19, 2014 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The doc should make it clear what cache invalidation is about

4 participants