Skip to content

Conversation

@ddeboer
Copy link
Member

@ddeboer ddeboer commented May 23, 2015

This will exclude some files and dirs when creating releases on GitHub. Smaller packages means faster downloads through Composer (using `--prefer-dist``) for our users. 😉

.gitattributes Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not need to say export-ignore here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops yes.

@dbu
Copy link
Contributor

dbu commented May 27, 2015

oh right, good idea! i guess one could also ignore the documentation folder - rst source code is not that helpful anyways.

@ddeboer
Copy link
Member Author

ddeboer commented May 27, 2015

Yeah, I wasn’t sure about the docs. I like to have them downloaded in case I end up coding somewhere without a proper internet connection (in the train, for instance). Although raw rst is not very legible, it’s better than nothing.

@ddeboer ddeboer force-pushed the smaller-packages branch from c4d8740 to 8485e9d Compare May 27, 2015 07:40
dbu added a commit that referenced this pull request May 27, 2015
Exclude files and dirs when building packages
@dbu dbu merged commit d3274be into master May 27, 2015
@dbu dbu deleted the smaller-packages branch May 27, 2015 11:07
@dbu
Copy link
Contributor

dbu commented May 27, 2015

docs could be a considerable part of the whole memory footprint, and there is always prefer-source for people who want everything included. but lets start with this. do you also copy this into the bundle? no need for a PR i guess, just push to master sounds fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants