fix accept header handling when client sends no accept header #133
+36
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Would it be possible to release this as 1.1.1 only (instead of both 1.0.2 and 1.1.1)? I think that will make maintenance easier, and as we use Semver, users can upgrade to 1.1 from 1.0 without trouble. |
Contributor
Author
|
i was pondering the same. i think we should do that, yes. otherwise it gets too complicated. a new minor release automatically obsoletes older minor releases. |
Contributor
Author
|
see #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we discovered this in a rest api where a client was sending requests without accept headers. this is not good practice but allowed by the http spec. if the backend only has one type of answer, it usually works out.
we accidentally converted this into an existing Accept header with empty value, which by the HTTP spec means the client is not accepting any format. leading a spec-adherent backend with no other option than raising a 4xx error.
once this is merged, i will merge 1.0 branch into master