Skip to content

CI-CD URL Check Change #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2023
Merged

CI-CD URL Check Change #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83b8234
Remove the Kernel's custom URL check to just use the CI-CD Actions one
Skptak Nov 8, 2023
6c4849a
Allow skipping the check for https://misra.org.uk/misra-c since it no…
Skptak Nov 8, 2023
344407f
Don't need to exclude the misra URL, now handled in the CI-CD repo. E…
Skptak Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 0 additions & 65 deletions .github/actions/url_verifier.sh
View file
Open in desktop

This file was deleted.

15 changes: 3 additions & 12 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ jobs:
- uses: actions/checkout@v3
- name: Check Formatting of FreeRTOS-Kernel Files
uses: FreeRTOS/CI-CD-Github-Actions/formatting@main
with:
exclude-dirs: portable

spell-check:
runs-on: ubuntu-latest
Expand All @@ -30,18 +32,7 @@ jobs:
- name: Clone This Repo
uses: actions/checkout@v3
- name: Link Verification
uses: FreeRTOS/CI-CD-Github-Actions/link-verifier@v2

url-check:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the kernel's custom script to instead use the CI-CD action that was already added and been used.

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
path: ./kernel

- name: URL Checker
run: |
bash kernel/.github/actions/url_verifier.sh kernel
uses: FreeRTOS/CI-CD-Github-Actions/link-verifier@main
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was incorrectly pointed to the v2 branch. Pointing back to mainline as part of this PR.


verify-manifest:
runs-on: ubuntu-latest
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/formatting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,7 @@ jobs:
runs-on: ubuntu-20.04
steps:
- name: Apply Formatting Fix
id: check-formatting
uses: FreeRTOS/CI-CD-Github-Actions/formatting-bot@main
id: check-formatting
with:
exclude-dirs: portable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not going to format the portable directory moving forward. Add this change to this PR to enable the PRs mentioned in the description to pass.