Allow decoding of SMBIOS Type 11 serialnumbers #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAZoidberg
force-pushed
the
smbios11-serialnums
branch
from
5fc3f51 to
7dd55b1
Compare
JohnAZoidberg
force-pushed
the
smbios11-serialnums
branch
from
7dd55b1 to
588d216
Compare
JohnAZoidberg
force-pushed
the
smbios11-serialnums
branch
from
588d216 to
d378c02
Compare
Member
|
cfg0 will struggle with keyboard which also use 'B' for some languages |
amstan
reviewed
Jun 6, 2025
framework_lib/src/smbios.rs
Outdated
| pub fn dump_oem_strings(strings: &SMBiosStringSet) { | ||
| for (i, s) in strings.into_iter().enumerate() { | ||
| let idx = i + 1; | ||
| let sn = match idx { |
Member
There was a problem hiding this comment.
It would be cooler if you didn't use idx positions for decoding the serial number (remember what happened last time these positions changed?). Just put them in a big array, shuffle them, and try to tell what each of them is based on the serial number contents.
Member
Author
There was a problem hiding this comment.
The order doesn't change, the factory also depends on it, as far as I remember.
Decoding the serialnumber is harder as we would have to embed all possible serialnumbers and I couldn't include those for unannounced projects.
JohnAZoidberg
force-pushed
the
smbios11-serialnums
branch
from
d378c02 to
35f0d76
Compare
They're the serialnumbers of what the system was originally assembled with in the factory. TODO - [ ] Cleanup code - [ ] Make safer with fewer unwraps - [ ] Custom command, not in info - [ ] Make sure date is decoded correctly - [ ] Support Framework 12 - [x] Support Framework 13 - [ ] Support Framework 16 Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
JohnAZoidberg
force-pushed
the
smbios11-serialnums
branch
from
35f0d76 to
630eec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're the serialnumbers of what the system was originally assembled with in the factory.
TODO