BUG: Serverless is no longer creating wrapper functions for serverless dashboard

[cbumstead]

Serverless dashboard creates wrapper functions for the handler methods which contains metadata used for logging lambda invocations. When serverless-jetpack plugin is used these wrapper functions do not get created and the lambda functions end up failing because the files and functions no longer exist. These functions are prefixed with s_ like s_my_function.js

To enable dashboard on an existing serverless project add app and tenant:

  # serverless.yml
  app: my-app
  tenant: my-company

[ryan-roemer]

Thanks for the bug report! So if I take a demo project and add those two lines I will hit the issue?

If so, how do I confirm I’ve hit the issue programmatically or inspection-wise?

[cbumstead]

Good question. The easiest way is to first create a simple serverless dashboard project without jetpack plugin with a single function.

# serverless.yml

service: test-service
app: my-app
tenant: my-company
    
provider:
  name: aws
  runtime: nodejs10.x
  region: us-west-2

functions:
  test:
    handler: handler.test

// handler.js

modules.exports = { test: (event, context) => return 'hello' }

Then run serverless deploy and notice that an s_test.js file is created.
Delete the s_test.js file.
Then add the jetpack plugin and run serverless deploy and notice the wrapper file is not generated.

[ryan-roemer]

I'm starting a WIP branch to reproduce the issue in our test fixtures with one that matches the above config. I haven't used any SLS enterprise features yet, and get this:

You are not currently logged in. To log in, use: $ serverless login

Is there any way to mock this / get the serverless package|deploy to still run?

WIP branch is at: master...bug/dashboard

[cbumstead]

Not that I know of. I would assume you would have to login for the dashboard feature to be enabled. But maybe there's a way to mock the login.

…

On Nov 16, 2019, at 8:22 AM, Ryan Roemer ***@***.***> wrote:  I'm starting a WIP branch to reproduce the issue in our test fixtures with one that matches the above config. I haven't used any SLS enterprise features yet, and get this: You are not currently logged in. To log in, use: $ serverless login Is there any way to mock this / get the serverless package|deploy to still run? WIP branch is at: master...bug/dashboard — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[ryan-roemer]

OK, I think I've got a reproduction now:

$ git checkout bug/dashboard
$ yarn
$ TEST_SCENARIO=dashboard yarn benchmark:build
$ TEST_SCENARIO=dashboard yarn benchmark:install
$ cd test/packages/dashboard/yarn

# Using `localdev` serverless enterprise token.
# Add `|| true` because of fake AWS creds causing finalize error.

# Build using serverless and verify `s_base.js`
$ SLS_DEBUG="*" \
  STAGE="sandbox" \
  AWS_REGION="us-east-1" \
  AWS_ACCESS_KEY_ID="fake" \
  AWS_SECRET_ACCESS_KEY="fake" \
  SERVERLESS_ACCESS_KEY="<SNIPPED>" \
  serverless package || true
$ unzip -p .serverless/serverless-jetpack-dashboard.zip s_base.js
# ==> Exists!

# Build using serverless and find `s_base.js` is missing
$ SLS_DEBUG="*" \
  STAGE="sandbox" \
  AWS_REGION="us-east-1" \
  AWS_ACCESS_KEY_ID="fake" \
  AWS_SECRET_ACCESS_KEY="fake" \
  SERVERLESS_ACCESS_KEY="<SNIPPED>" \
  MODE=yarn \
  serverless package || true
$ unzip -p .serverless/serverless-jetpack-dashboard.zip s_base.js
# ==> Not found!

That s_base.js wraps the existing entry point...

Will investigate more if I can programmatically get a regression test (but it's hard because so far both serverless loging (env var) and working AWS creds are required to get a real package done (ugh)).

After that will investigate a fix. Hopefully it's just calling a plugin lifecycle or something...

[ryan-roemer]

Ah, a little debugging reveals that jetpack and the enterprise plugin hook into the same lifecycle hook, and that jetpack packages first, then the wrapper is created if I'm reading this right. (Need a little more research here):

Serverless: [serverless-jetpack] Packaging 0 functions, 1 services, and 0 layers with concurrency 1
Serverless: [serverless-jetpack] Start packaging service: .serverless/serverless-jetpack-dashboard.zip
Serverless: [serverless-jetpack] Zipped 350 sources from /Users/rye/scm/fmd/serverless-jetpack/test/packages/dashboard/yarn to artifact location: /Users/rye/scm/fmd/serverless-jetpack/test/packages/dashboard/yarn/.serverless/serverless-jetpack-dashboard.zip
Serverless: [serverless-jetpack] Packaged service: .serverless/serverless-jetpack-dashboard.zip (1.01s)
TODO(@serverless/enterprise-plugin) HERE { hook: 'before:package:createDeploymentArtifacts' }

[ryan-roemer]

Ugh. Also looks like serverless hard-codes the @serverless/enterprise-plugin last:

// serverless/lib/classes/PluginManager.js
  loadAllPlugins(servicePlugins) {
    [
      ...require('../plugins'),
      ...this.resolveServicePlugins(servicePlugins),
      this.resolveEnterprisePlugin(), // That's `@serverless/enterprise-plugin`
    ]
      .filter(Boolean)
      .forEach(Plugin => this.addPlugin(Plugin));
    return this.asyncPluginInit();
  }

(It also filters it out if a user configs it in serverless.yml plugins section).

[ryan-roemer]

@cbumstead I have a hacky patch that's still majorly WIP, but would love to hear if it works from an inputs and outputs perspective (as well as not having negative side effects.

Branch is at bug/dashboard.

Thanks!

[cbumstead]

@ryan-roemer I just tested the fix in the bug/dashboard branch and I now see the serverless dashboard files being generated correctly and I was able to deploy and run the lambda using the jetpack plugin.

Thanks for the quick fix!