Remove str concatenation #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justmobilize
commented
May 3, 2024
| @@ -369,22 +369,22 @@ def _build_boundary_data(self, files: dict): # pylint: disable=too-many-locals | |||
| file_name = field_values[0] | |||
| file_handle = field_values[1] | |||
|
|
|||
| boundary_data = f"--{boundary_string}\r\n" | |||
| boundary_data += f'Content-Disposition: form-data; name="{field_name}"' | |||
| boundary_objects.append( | |||
There was a problem hiding this comment.
add all strings to the list
| boundary_objects.append(boundary_data) | ||
| for boundary_object in boundary_objects: | ||
| if isinstance(boundary_object, str): | ||
| content_length += len(boundary_object) |
There was a problem hiding this comment.
and calculate the length at the end
| @@ -10,13 +10,15 @@ envlist = py311 | |||
| description = run tests | |||
| deps = | |||
| pytest==7.4.3 | |||
| requests | |||
There was a problem hiding this comment.
needed to run tox, since requests is now in optional
|
Thank you! Looks good to me, I tested this successfully on a Feather S3 TFT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.