Skip to content

Add tests #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Add tests #3

merged 3 commits into from
Apr 29, 2024

Conversation

justmobilize
Copy link

No description provided.

@justmobilize
Copy link
Author

@FoamyGuy w00t! Ask and you shall receive! This uses actual requests to compare the payload sent.

@justmobilize justmobilize marked this pull request as ready for review April 28, 2024 01:26
Copy link
Owner

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justmobilize Awesome! Thank you 🎉

I committed a few tweaks:

  • changed copyright name and year from the copy/pasted ones to you / current.
  • moved requests to optional_requirements.txt instead of requirements.txt. CPython requests is needed to run the tests, but isn't needed for anyone who is just installing adafruit_requests via pip to use as normal instead of running the tests.
  • added timeouts to the cpython_requests.post() calls. Locally my pylint was failing due to those not having timeouts, this way the test cannot get stuck indefinitely.

@FoamyGuy FoamyGuy merged commit a8b78ad into FoamyGuy:files_arg Apr 29, 2024
1 check passed
@justmobilize justmobilize deleted the files_arg_tests branch April 30, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants