Simple fix for kron(::AbstractVector) on nightly
#1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarloLucibello
approved these changes
Feb 26, 2023
ToucheSir
added a commit
to FluxML/Tracker.jl
that referenced
this pull request
Jul 8, 2023
Copying over the change from FluxML/Zygote.jl#1378.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should get nightly CI
greencloser to green again (Edit: see #1379 for the missing piece) so we're not constantly having to check for false positives. Longer term, the proper solution will be JuliaDiff/ChainRules.jl#684.PR Checklist