fix the torchvision porting script #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I guess #206 is a good reason for uploading on HF. Or we want to fix the issue mapping the old weights to the new implementations? |
Member
|
We can upload new weights, but I don't think running the script is the issue. All these weights already exist on HF, and they can be accessed on master. The issue is that BSON won't load models saved with Julia 1.7+ because So I would say re-running this script with Julia 1.6, then uploading those weights will fix all the issues. |
darsnack
reviewed
Apr 24, 2023
darsnack
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The models left uncommented in the
model_listin theport_torchvision.jlscript are successfully ported from torchvision(on julia 1.9 rc2). Is there any need to reupload them on HuggingFace?
For SqueezeNet and DenseNet the script errors due to size mismatches. Maybe wrong ordering again?
close #228