Skip to content

add some space to the end of the scrollviewer #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2021
Merged

add some space to the end of the scrollviewer #579

merged 1 commit into from
Jul 19, 2021

Conversation

@taooceros
Copy link
Member

When user scroll down to the end, it will have some space around there.

pc223
pc223 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@pc223 pc223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like expected on my machine

@jjw24 jjw24 merged commit 5fcef84 into dev Jul 19, 2021
@jjw24 jjw24 deleted the setting_window_extra_space branch July 19, 2021 23:09
@jjw24 jjw24 added this to the 1.9.0 milestone Jul 19, 2021
@jjw24 jjw24 added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jul 19, 2021
@jjw24 jjw24 mentioned this pull request Jul 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pc223 pc223 pc223 approved these changes

@jjw24 jjw24 jjw24 approved these changes

Assignees

@pc223 pc223

Labels

bug Something isn't working

Projects

None yet

Milestone

1.8.1

Development

Successfully merging this pull request may close these issues.

4 participants

@taooceros @pc223 @jjw24