Use ResultContextMenu instead of ContextMenu #3600

Jack251970 · 2025-05-31T09:17:41Z

We should use ResultContextMenu instead of ContextMenu because for Window, it already has one element called ContextMenu.

github-actions · 2025-05-31T09:18:34Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings	Count
❌ forbidden-pattern	24
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

gitstream-cm · 2025-05-31T09:18:36Z

🥷 Code experts: onesounds

onesounds, Jack251970 have most 👩‍💻 activity in the files.
onesounds, Jack251970 have most 🧠 knowledge in the files.

See details

Flow.Launcher/MainWindow.xaml

Activity based on git-commit:

	onesounds	Jack251970
MAY	4 additions & 4 deletions
APR
MAR		42 additions & 26 deletions
FEB		1 additions & 1 deletions
JAN
DEC

Knowledge based on git-blame:
onesounds: 85%
Jack251970: 6%

Flow.Launcher/MainWindow.xaml.cs

Activity based on git-commit:

	onesounds	Jack251970
MAY	5 additions & 1 deletions	130 additions & 33 deletions
APR	5 additions & 1 deletions	69 additions & 45 deletions
MAR	327 additions & 141 deletions	1141 additions & 1076 deletions
FEB	8 additions & 4 deletions	1 additions & 1 deletions
JAN
DEC		5 additions & 10 deletions

Knowledge based on git-blame:
Jack251970: 68%
onesounds: 14%

Flow.Launcher/SettingPages/Views/SettingsPaneTheme.xaml

Activity based on git-commit:

	onesounds	Jack251970
MAY		1 additions & 1 deletions
APR	25 additions & 10 deletions	35 additions & 10 deletions
MAR	174 additions & 149 deletions	62 additions & 35 deletions
FEB
JAN
DEC

Knowledge based on git-blame:
onesounds: 78%
Jack251970: 4%

Flow.Launcher/Themes/Base.xaml

Activity based on git-commit:

	onesounds	Jack251970
MAY
APR	8 additions & 0 deletions
MAR	65 additions & 62 deletions	4 additions & 3 deletions
FEB
JAN
DEC

Knowledge based on git-blame:
onesounds: 70%
Jack251970: 1%

To learn more about /:\ gitStream - Visit our Docs

gitstream-cm · 2025-05-31T09:18:44Z

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Copilot

Pull Request Overview

Replaces the old ContextMenu element with ResultContextMenu to avoid naming conflicts with WPF’s built-in ContextMenu and updates associated visibility triggers and code-behind logic.

Renamed XAML elements and bindings from ContextMenu to ResultContextMenu
Updated visibility triggers and data triggers to reference ResultContextMenu
Adjusted code-behind subscribers and null checks to use ResultContextMenu

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
Flow.Launcher/Themes/Base.xaml	Swapped out the commented `ContextMenu` trigger for `ResultContextMenu`
Flow.Launcher/SettingPages/Views/SettingsPaneTheme.xaml	Renamed `<Border x:Name="ContextMenu">` to `ResultContextMenu`
Flow.Launcher/MainWindow.xaml.cs	Updated `DependencyPropertyDescriptor` subscriptions and null checks to use `ResultContextMenu`
Flow.Launcher/MainWindow.xaml	Updated bindings, triggers, and `x:Name` from `ContextMenu` to `ResultContextMenu`

Copilot · 2025-05-31T09:19:23Z

Flow.Launcher/MainWindow.xaml.cs


            // Detect History.Visibility changes
            DependencyPropertyDescriptor
-                .FromProperty(VisibilityProperty, typeof(StackPanel))
+                .FromProperty(VisibilityProperty, typeof(ResultListBox))


The owner type for the History subscription should match the actual control type (e.g., StackPanel or Border) rather than ResultListBox, otherwise the Descriptor may not fire when History.Visibility changes.

Suggested change

.FromProperty(VisibilityProperty, typeof(ResultListBox))

.FromProperty(VisibilityProperty, typeof(StackPanel)) // Replace ResultListBox with the actual type of History

@Jack251970 is this relevant?

Copilot · 2025-05-31T09:19:24Z

Flow.Launcher/Themes/Base.xaml

                    <!--
                    <Condition Binding="{Binding ElementName=ResultListBox, Path=Visibility}" Value="Collapsed" />
-                    <Condition Binding="{Binding ElementName=ContextMenu, Path=Visibility}" Value="Collapsed" />-->
+                    <Condition Binding="{Binding ElementName=ResultContextMenu, Path=Visibility}" Value="Collapsed" />-->


[nitpick] The comment block opens on line 480 but closes here, which can be hard to follow; consider using a single-line comment () or moving both markers onto each individual line to improve readability.

coderabbitai · 2025-05-31T09:22:07Z

📝 Walkthrough

Walkthrough

The changes systematically rename a XAML UI element and its references from "ContextMenu" to "ResultContextMenu" across multiple files. This update affects element names, bindings, event subscriptions, and trigger conditions related to result list context menus in both the main window and theme resources, without altering underlying logic or structure.

Changes

Files	Change Summary
Flow.Launcher/MainWindow.xaml, Flow.Launcher/SettingPages/Views/SettingsPaneTheme.xaml	Renamed XAML element and references from "ContextMenu" to "ResultContextMenu"
Flow.Launcher/MainWindow.xaml.cs	Updated all code references and event subscriptions from "ContextMenu" to "ResultContextMenu"
Flow.Launcher/Themes/Base.xaml	Changed commented-out trigger binding from "ContextMenu" to "ResultContextMenu"

Suggested labels

kind/ui

Suggested reviewers

jjw24
taooceros

Poem

A menu once called "Context" by name,
Now "ResultContextMenu" joins the fame!
With bindings and triggers all tidy and neat,
The UI flows on with a rhythmic beat.
🐇✨
Rename complete, let’s hop to the next feat!

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

Flow.Launcher/Themes/Base.xaml (1)

482-482: Remove outdated commented-out condition
The commented-out <Condition> referencing ResultContextMenu is vestigial. Consider removing it to declutter the resource dictionary and prevent confusion.

Flow.Launcher/MainWindow.xaml (1)

376-378: Clean up commented style triggers
The commented <DataTrigger> block for ResultContextMenu has been updated but remains commented out. Remove or restore it based on whether this logic is required to avoid stale code.

🧰 Tools

🪛 GitHub Actions: Check Spelling

[warning] 460-31: VSTHRD is not a recognized word. (unrecognized-spelling)

[warning] 475-31: VSTHRD is not a recognized word. (unrecognized-spelling)

[warning] 487-31: VSTHRD is not a recognized word. (unrecognized-spelling)

[warning] 491-27: Wnd is not a recognized word. (unrecognized-spelling)

[warning] 493-27: Wnd is not a recognized word. (unrecognized-spelling)

[warning] 564-30: WMP is not a recognized word. (unrecognized-spelling)

[warning] 566-34: WMP is not a recognized word. (unrecognized-spelling)

[warning] 567-34: WMP is not a recognized word. (unrecognized-spelling)

[warning] 568-34: WMP is not a recognized word. (unrecognized-spelling)

[warning] 648-25: gamemode is not a recognized word. (unrecognized-spelling)

[warning] 649-25: gamemode is not a recognized word. (unrecognized-spelling)

[warning] 652-32: gamemode is not a recognized word. (unrecognized-spelling)

[warning] 655-30: positionreset is not a recognized word. (unrecognized-spelling)

[warning] 658-37: positionreset is not a recognized word. (unrecognized-spelling)

[warning] 674-21: gamemode is not a recognized word. (unrecognized-spelling)

[warning] 675-26: positionreset is not a recognized word. (unrecognized-spelling)

[warning] 680-26: positionreset is not a recognized word. (unrecognized-spelling)

[warning] 790-64: XRatio is not a recognized word. (unrecognized-spelling)

[warning] 791-63: YRatio is not a recognized word. (unrecognized-spelling)

[warning] 1005-20: clocksb is not a recognized word. (unrecognized-spelling)

[warning] 1006-20: clocksb is not a recognized word. (unrecognized-spelling)

[warning] 1007-19: iconsb is not a recognized word. (unrecognized-spelling)

[warning] 1008-19: iconsb is not a recognized word. (unrecognized-spelling)

[warning] 1013-20: clocksb is not a recognized word. (unrecognized-spelling)

[warning] 1014-19: iconsb is not a recognized word. (unrecognized-spelling)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31cba99 and 70fcc84.

📒 Files selected for processing (4)

Flow.Launcher/MainWindow.xaml (3 hunks)
Flow.Launcher/MainWindow.xaml.cs (3 hunks)
Flow.Launcher/SettingPages/Views/SettingsPaneTheme.xaml (1 hunks)
Flow.Launcher/Themes/Base.xaml (1 hunks)

🧰 Additional context used

🪛 GitHub Actions: Check Spelling

Flow.Launcher/MainWindow.xaml

[warning] 83-25: Ioc is not a recognized word. (unrecognized-spelling)

[warning] 84-29: Ioc is not a recognized word. (unrecognized-spelling)

[warning] 111-36: Wnd is not a recognized word. (unrecognized-spelling)

[warning] 336-43: Wnd is not a recognized word. (unrecognized-spelling)

[warning] 460-31: VSTHRD is not a recognized word. (unrecognized-spelling)

[warning] 475-31: VSTHRD is not a recognized word. (unrecognized-spelling)

[warning] 487-31: VSTHRD is not a recognized word. (unrecognized-spelling)

[warning] 491-27: Wnd is not a recognized word. (unrecognized-spelling)

[warning] 493-27: Wnd is not a recognized word. (unrecognized-spelling)

[warning] 564-30: WMP is not a recognized word. (unrecognized-spelling)

[warning] 566-34: WMP is not a recognized word. (unrecognized-spelling)

[warning] 567-34: WMP is not a recognized word. (unrecognized-spelling)

[warning] 568-34: WMP is not a recognized word. (unrecognized-spelling)

[warning] 648-25: gamemode is not a recognized word. (unrecognized-spelling)

[warning] 649-25: gamemode is not a recognized word. (unrecognized-spelling)

[warning] 652-32: gamemode is not a recognized word. (unrecognized-spelling)

[warning] 655-30: positionreset is not a recognized word. (unrecognized-spelling)

[warning] 658-37: positionreset is not a recognized word. (unrecognized-spelling)

[warning] 674-21: gamemode is not a recognized word. (unrecognized-spelling)

[warning] 675-26: positionreset is not a recognized word. (unrecognized-spelling)

[warning] 680-26: positionreset is not a recognized word. (unrecognized-spelling)

[warning] 790-64: XRatio is not a recognized word. (unrecognized-spelling)

[warning] 791-63: YRatio is not a recognized word. (unrecognized-spelling)

[warning] 1005-20: clocksb is not a recognized word. (unrecognized-spelling)

[warning] 1006-20: clocksb is not a recognized word. (unrecognized-spelling)

[warning] 1007-19: iconsb is not a recognized word. (unrecognized-spelling)

[warning] 1008-19: iconsb is not a recognized word. (unrecognized-spelling)

[warning] 1013-20: clocksb is not a recognized word. (unrecognized-spelling)

[warning] 1014-19: iconsb is not a recognized word. (unrecognized-spelling)