Add Toggle History hotkey functionality and binding

[onesounds]

What's the PR

• Make the toggle history shortcut key configurable.
• Resolve How to change the history (ctrl-h) shortcut? #3162

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings	Count
❌ forbidden-pattern	22
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gitstream-cm]

🥷 Code experts: Jack251970, Yusyuriv

Jack251970 has most 👩‍💻 activity in the files.
Jack251970, onesounds have most 🧠 knowledge in the files.

See details

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

Activity based on git-commit:

	Jack251970
MAY	41 additions & 19 deletions
APR	34 additions & 83 deletions
MAR	142 additions & 94 deletions
FEB	10 additions & 4 deletions
JAN	17 additions & 4 deletions
DEC	1 additions & 1 deletions

Knowledge based on git-blame:
Jack251970: 26%
onesounds: 21%

Flow.Launcher/HotkeyControl.xaml.cs

Activity based on git-commit:

	Jack251970
MAY
APR	11 additions & 15 deletions
MAR	150 additions & 37 deletions
FEB
JAN
DEC

Knowledge based on git-blame:
Jack251970: 45%

Flow.Launcher/MainWindow.xaml

Activity based on git-commit:

	Jack251970
MAY
APR
MAR	42 additions & 26 deletions
FEB	1 additions & 1 deletions
JAN
DEC

Knowledge based on git-blame:
onesounds: 85%
Jack251970: 6%

Flow.Launcher/SettingPages/Views/SettingsPaneHotkey.xaml

Activity based on git-commit:

	Jack251970
MAY
APR
MAR	14 additions & 28 deletions
FEB
JAN
DEC

Knowledge based on git-blame:
onesounds: 10%
Jack251970: 3%

Flow.Launcher/ViewModel/MainViewModel.cs

Activity based on git-commit:

	Jack251970
MAY	529 additions & 316 deletions
APR	35 additions & 28 deletions
MAR	695 additions & 628 deletions
FEB	63 additions & 21 deletions
JAN	17 additions & 21 deletions
DEC	59 additions & 63 deletions

Knowledge based on git-blame:
Jack251970: 40%
onesounds: 9%

To learn more about /:\ gitStream - Visit our Docs

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

A new customizable hotkey, OpenHistoryHotkey, with a default value of "Ctrl+H", was introduced for opening history. The property is now part of user settings and can be configured via the UI. All references to the previously fixed "Ctrl+H" hotkey were replaced with dynamic bindings using this new setting.

Changes

File(s)	Change Summary
Flow.Launcher.Infrastructure/UserSettings/Settings.cs	Added OpenHistoryHotkey property to settings and included it in customizable hotkeys.
Flow.Launcher/HotkeyControl.xaml.cs	Extended HotkeyType enum and updated getter/setter to support OpenHistoryHotkey.
Flow.Launcher/MainWindow.xaml	Replaced hardcoded Ctrl+H binding for history with dynamic binding to OpenHistoryHotkey.
Flow.Launcher/SettingPages/Views/SettingsPaneHotkey.xaml	Switched static hotkey display for history to an interactive, user-configurable hotkey control.
Flow.Launcher/ViewModel/MainViewModel.cs	Added OpenHistoryHotkey property and property change notification for the new setting.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingsPane
    participant Settings
    participant MainWindow
    participant MainViewModel

    User->>SettingsPane: Changes OpenHistoryHotkey via HotkeyControl
    SettingsPane->>Settings: Updates OpenHistoryHotkey property
    Settings-->>MainViewModel: Notifies PropertyChanged (OpenHistoryHotkey)
    MainViewModel-->>MainWindow: Raises OnPropertyChanged (OpenHistoryHotkey)
    MainWindow->>MainWindow: Updates key binding for LoadHistoryCommand
    User->>MainWindow: Presses new OpenHistoryHotkey
    MainWindow->>MainWindow: Executes LoadHistoryCommand

Loading

Suggested labels

enhancement

Suggested reviewers

• Jack251970

Poem

A hop and a skip, with keys in my paw,
Now Ctrl+H can open history—ooh la la!
Custom hotkeys abound,
In settings they're found,
With a twitch of my nose,
I bind what I chose,
And history opens with awe! 🐇⌨️

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6144d4a and 05486ea.

📒 Files selected for processing (5)

• Flow.Launcher.Infrastructure/UserSettings/Settings.cs (2 hunks)
• Flow.Launcher/HotkeyControl.xaml.cs (3 hunks)
• Flow.Launcher/MainWindow.xaml (1 hunks)
• Flow.Launcher/SettingPages/Views/SettingsPaneHotkey.xaml (1 hunks)
• Flow.Launcher/ViewModel/MainViewModel.cs (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

Flow.Launcher/ViewModel/MainViewModel.cs (1)

Flow.Launcher.Infrastructure/UserSettings/Settings.cs (1)

• Settings (16-491)

🪛 GitHub Actions: Check Spelling

Flow.Launcher/HotkeyControl.xaml.cs

[warning] 118-118: Spell check warning: Ioc is not a recognized word. (unrecognized-spelling)

---

[warning] 261-261: Spell check warning: EResult is not a recognized word. (unrecognized-spelling)

---

[warning] 264-264: Spell check warning: EResult is not a recognized word. (unrecognized-spelling)

Flow.Launcher/ViewModel/MainViewModel.cs

[warning] 72-72: Spell check warning: Ioc is not a recognized word. (unrecognized-spelling)

---

[warning] 1849-1849: Spell check warning: VSTHRD is not a recognized word. (unrecognized-spelling)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: gitStream.cm
• GitHub Check: build

🔇 Additional comments (9)

Flow.Launcher.Infrastructure/UserSettings/Settings.cs (2)

53-53: LGTM! Well-implemented configurable hotkey property.

The new OpenHistoryHotkey property follows the existing pattern perfectly with an appropriate default value that maintains backward compatibility.

---

430-431: Correct registration in customizable hotkeys list.

The registration follows the established pattern and enables the hotkey to be cleared or reset through the settings infrastructure.

Flow.Launcher/SettingPages/Views/SettingsPaneHotkey.xaml (1)

92-95: Excellent UI transformation from static to configurable control.

The change from HotkeyDisplay to HotkeyControl correctly enables user customization while maintaining consistency with other configurable hotkeys. The configuration values match the corresponding settings property.

Flow.Launcher/MainWindow.xaml (1)

190-193: Perfect implementation of dynamic hotkey binding.

The conversion from hardcoded "Ctrl+H" to dynamic binding using StringToKeyBindingConverter follows the established pattern perfectly and enables runtime hotkey configuration.

Flow.Launcher/HotkeyControl.xaml.cs (3)

103-103: Correct enum addition for the new hotkey type.

The OpenHistoryHotkey enum value is properly placed and follows the naming convention.

---

134-134: Proper implementation of hotkey property handling.

Both getter and setter implementations correctly follow the established pattern, mapping to the appropriate settings property.

Also applies to: 171-173

---

118-118: Pipeline spelling warnings are false positives.

The spelling warnings for "Ioc" (Inversion of Control) and "EResult" (enum naming) are technical terms and not actual issues.

🧰 Tools

🪛 GitHub Check: Check Spelling

[warning] 118-118:
Ioc is not a recognized word. (unrecognized-spelling)

🪛 GitHub Actions: Check Spelling

[warning] 118-118: Spell check warning: Ioc is not a recognized word. (unrecognized-spelling)

Flow.Launcher/ViewModel/MainViewModel.cs (2)

140-142: LGTM! Consistent implementation of property change notification.

The event handler addition follows the exact same pattern as all other hotkey settings in this file. The implementation correctly listens for changes to the OpenHistoryHotkey property and raises the appropriate OnPropertyChanged notification for the view model property.

---

892-892: LGTM! Property implementation follows established patterns.

The OpenHistoryHotkey property is correctly implemented using the same pattern as all other hotkey properties in this file. It properly uses the VerifyOrSetDefaultHotkey helper method with the settings value and provides the appropriate default value of "Ctrl+H" that matches the Settings class definition.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.