Fix Shared Assembly Issue #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
let's keep this for 1.10.0 so it can go through daily usage tests longer. |
Member
Author
|
This one will break Plugins with shared assembly (for example sqlite). So somehow user may encounter weird issue when installing multiple plugin. |
jjw24
approved these changes
Mar 1, 2022
Member
jjw24
left a comment
jjw24
left a comment
There was a problem hiding this comment.
no need underscores for privates :)
Member
Oh ok, in this case let's roll out for 1.9.3 then. |
Member
|
@taooceros could this potentially solve #1048 and #1046 ? |
Member
Author
I don't think so. They are not related to assembly loading. |
Merged
jjw24
added a commit
that referenced
this pull request
Mar 3, 2022
## Bug fixes - Addresses the issue where WindowsSettings plugin results appear higher than other results #1020 - Fixed an issue where full screen mode does not disable hotkey when enabled #1037 - Fixed some potential issues when loading plugins that use shared assembly #1036 - Sorted out a race condition issue causing image loading on some results to fail #1040 - Revised ttf/otf support #935 - Resolved the issue where WebSearch plugin would crash if not connected to internet #977 - Fixed incorrect text for "New Tab" and "New Window" buttons under Settings' default browser section #951 - Fixed typos in plugin title and WindowsSettings name inside the context menu #1056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where multiple plugins using shared assembly like SQLite, the ones loaded later will not be able to access the shared assembly.
Previous I check all the loaded assembly before allowing the pluginassemblyloader to load the assembly. However, this doesn't seem like a good practice, since this will prevent a assembly context to load the same assembly if another assembly context has already loaded it (which are isolated).
I have tested it for the winrt.dll situation as well. The default assembly loader will load the winrt.dll before we trigger a deferred load so all assembly should be good with that. However, I am curious whether we should match with Name instead of FullName.