Skip to content

Engine V7 compatibility #144

@khvn26

Description

@khvn26

After #143 is merged, remove all imports and references to flag_engine package, except get_evaluation_results interface introduced in Flagsmith/flagsmith-engine#234.

The list of imports to remove:

flagsmith/flagsmith.py:9,6: from flag_engine.environments.models import EnvironmentModel
flagsmith/flagsmith.py:10,6: from flag_engine.identities.models import IdentityModel
flagsmith/flagsmith.py:11,6: from flag_engine.identities.traits.models import TraitModel 
flagsmith/models.py:6,6: from flag_engine.features.models import FeatureStateModel
flagsmith/offline_handlers.py:3,6: from flag_engine.environments.models import EnvironmentModel

This should include a backwards-incompatible change to OfflineHandler signature. Right now, I believe that offline handlers should return an EvaluationContext dictionary, but it's a subject to discussion during further scoping of the issue.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions