Change cache key for getIdentityFlagsFromApi #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getIdentityFlagsFromApi should not be using the Global cache key prefix
matthewelwell
requested changes
Feb 22, 2024
…omatic discovery of HTTP clients 🐛 fix(Flagsmith.php): add cache key generation for identities to improve caching efficiency 🐛 fix(IdentitiesGenerator.php): add method to generate cache key for identities based on identifier and traits to ensure uniqueness
Contributor
Author
|
@matthewelwell can this be merged? |
matthewelwell
approved these changes
Mar 14, 2024
Contributor
Author
|
@dabeeeenster @matthewelwell would you mind issuing a release |
Contributor
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getIdentityFlagsFromApi should not be using the Global cache key prefix