Fix invalid cache value #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gagantrivedi
approved these changes
Nov 7, 2023
Contributor
Author
|
Thanks @gagantrivedi, is it possible to tag a new release :) |
Member
Yeah, once #59 is approved (in a couple of hours) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @matthewelwell,
I recently got an error
Which is caused by the cachedCall returning null.
I'm not sure if it's a bad luck about the ttl expiring between the
hascall and thegetcall (therefor returning null)or if it's because we had invalid values in the cache or any other reason...
But when using cache, I assume flagsmith should get the value and check it's an array/object before returning it. (In order to respect the phpdoc of the method)