enableLocalEvaluation can only be enabled if `withEnvironmentTtl` is specified in the consturctor

[predrag-nikolic-kombinat-dev]

Based on the docs:

    /*
    Set environment refresh rate with polling manager.
    This also enables local evaluation.
    Optional.
    Defaults to null
    */
    int $environmentTtl = null,

enableLocalEvaluation will only be enabled if I provide environmentTtl through the constructor new Flagsmith("KEY", null, null, 100) ,
but not when you do (new Flagsmith("KEY"))->withEnvironmentTtl(100)... because $this->enableLocalEvaluation is only set in the constructor.

class Flagsmith
{
    public function __construct(
        string $apiKey = null,
        string $host = null,
        object $customHeaders = null,
        int $environmentTtl = null,
        ...
    ) {
       $this->enableLocalEvaluation = !is_null($environmentTtl);

I do expect that the current API withEnvironmentTtl set enableLocalEvaluation to true.

---

But ideally other flagsmith clients do have a more explict API, for example, the Java client has .withLocalEvaluation(true), python has enable_local_evaluation , JavaScript has enableLocalEvaluation.

[matthewelwell]

@predrag-nikolic-kombinat-dev this seems like a duplicate of #99 so I'll close this for now, but let me know if you disagree.

[predrag-nikolic-kombinat-dev]

Helllo @matthewelwell 👋

this ticket #101 is different from #99

In #99 the docs should be clearer that it is the responsibility of the developer integrating the Flagsmith client to add the cron job to update the environment cache. (as you wrote :) )

---

in #101 calling (new Flagsmith("KEY"))->withEnvironmentTtl(100) will not currently enable enableLocalEvaluation,
but I do expect that the current API withEnvironmentTtl to set enableLocalEvaluation to true.

The reason why I think that is the expected behavior
is because I read: $environmentTtl also enables local evaluation.

    /*
    This also enables local evaluation.
    Optional.
    Defaults to null
    */
    int $environmentTtl = null,

The only way currently in the FlagSmith PHP client to enable local evaluation is to specify environmentTtl through the constructor new Flagsmith("KEY", null, null, 100) // note the fourth argument is the place to specify $environmentTtl

So the improvement here,
is to make sure that withEnvironmentTtl also enables enableLocalEvaluation

[matthewelwell]

@predrag-nikolic-kombinat-dev feel free to submit a PR to add this behaviour, thanks!

[predrag-nikolic-kombinat-dev]

Hello @matthewelwell,
I don't understand your reasoning for your above reply.
Can we reopen this ticket as it is not the same as #99 (I cannot re-open the ticket because the reopen button is disabled)

[matthewelwell]

@predrag-nikolic-kombinat-dev no, I do not want to re-open this ticket. I think the way forwards from here is to create a new issue that encompasses (and hence supersedes) both #99 and #101 (and probably #100 once we've investigated the issues further) which covers improving the developer experience for using local evaluation in our PHP client.

Please leave this with me and I will create a new issue which links out to each of the issues. The reason that I'd like to do this, is that I don't want to tackle individual cases when perhaps a more global solution is the right path forwards. I hope that makes sense and you understand the reasoning.

[predrag-nikolic-kombinat-dev]

Ok, @matthewelwell what you wrote makes more sense.
Thanks for explaining