feat: Implement Context values for Segments #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
added a commit
to Flagsmith/flagsmith-nodejs-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-php-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-elixir-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-rust-flag-engine
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-go-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-dotnet-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-java-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-ruby-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-go-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-ruby-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-nodejs-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-php-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-elixir-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-rust-flag-engine
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-dotnet-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
khvn26
added a commit
to Flagsmith/flagsmith-java-client
that referenced
this pull request
Jul 21, 2025
Required to merge Flagsmith/engine-test-data#8.
Contributor
Co-authored-by: Kim Gustyr <[email protected]>
Zaimwa9
reviewed
Oct 3, 2025
Contributor
There was a problem hiding this comment.
Yet to dig into the details of the tests but out of my mind I have 3 comments:
- Can we come up with human filenames ? To avoid redundancy because of not getting where to look at
- I see here the common usage anticipated, would it be worth to have a pre.commit script that aggregates the test into one
index.json? - And a mix of my 2 above comments, keep the files separately accessibles but with an understandable name (cf here)
emyller
approved these changes
Oct 3, 2025
Contributor
emyller
left a comment
emyller
left a comment
There was a problem hiding this comment.
I mostly agree with @Zaimwa9, and honestly don't see actual improvements to existing test data.
That said, I'm approving because improving names might be out of scope here. This work should already unblock moving forward with adding new test cases.
Member
Author
Created #17 to address this. I agree with @emyller that further modifications should be out of scope of this PR; here, we solve transforming existing test data, and adding one test case for context values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to Flagsmith/flagsmith-engine#219.
Closes #11.
In this PR, we:
I've decided to use a JSONSchema spec for the test case data so it's self-documented and easily consumed.
We should release v2.0.0 once this is merged.