[FB4, GBAK] Correct handling of NULLs in RDB$RETURN_ARGUMENT and RDB$ARGUMENT_POSITION #7870
Conversation
…T_POSITION to NULL value This is a fix for issue FirebirdSQL#7869 - potential problem of writing into database the uninitialized value in RDB$RETURN_ARGUMENT and RDB$ARGUMENT_POSITION columns. get_function - inits X.RDB$RETURN_ARGUMENT.NULL - IF >=DB_VERSION_DDL12 - ELSE get_function_arg - inits X.RDB$ARGUMENT_POSITION.NULL - IF >=DB_VERSION_DDL12 - IF >=DB_VERSION_DDL10 - ELSE
|
I'm still sure that fld_f_position must be not nullable to prevent UB in engine. |
Me too but it is a change of ODS and I am too young to ask and suggest such changes. |
|
Is it really an ODS change? No field added or deleted, no even unique index/constraint put here (though one won't hurt). Old code should work with new definition flawlessly and vice versa. |
|
In real life, this looks like more as a code improvement, and a partial one. |
I can added these changes to master and fb5, too. I want to add these changes to FB4, because I work with this version and they are needed to fix another problem with UDF SCALAR_ARRAY arguments (#7846, #7845) |
…h NULL value. Thanks to Adriano. This is a fix for symmetric problem with RDB$RETURN_ARGUMENT and RDB$ARGUMENT_POSITION in backup. write_functions write_function_args
|
Hello. Please, let me know if I must create equal PR for FB5 and master. It is not a problem for me. Thanks. |
dmitry-lipetsk
changed the title
4 participants
This is a fix for issue #7869 - a potential problem of writing into database the uninitialized value in RDB$RETURN_ARGUMENT and RDB$ARGUMENT_POSITION columns.
Of course, GBAK has a lot of equal problems for other columns but I want to fix a problem only with these ones.
UPD1. Symmetric problem in backup is fixed. Thanks to Adriano.