This repository was archived by the owner on Mar 17, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 493
Firebase.readEvent() returns "type" instead "put" while getting data from Firebase #374
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e62c217
Firebase.readEvent() returns "type" instead "put" while getting data …
kptdobe b14884a
Use proper API
kptdobe 50a5865
Use correct syntax and api
kptdobe 434df1c
Try with explicit objects
kptdobe a2a9896
Issue comes from the set during the tests...
kptdobe 5746cb5
Checking tests with latest ArduinoJson lib version
kptdobe d330ced
Maybe...
kptdobe e4713f7
Another test
kptdobe 2b47534
Another test...
kptdobe f1c940d
Give up...
kptdobe 728dd9d
Test with ESP8266 2.4.1
kptdobe 74f63e2
Revert "Test with ESP8266 2.4.1"
kptdobe db84569
Quick final test
kptdobe f08825d
Revert "Quick final test"
kptdobe 3af3a1a
Fixed!
kptdobe 3195d23
Integrated feedback
kptdobe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't that leak?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah missed the delete, I was thinking it might not be safe to delete if JsonVariant keep a ref on it.
But set() documentation seems to imply that it make a copy if you pass a char* https://arduinojson.org/v5/api/jsonobject/set/.