Skip to content

fix(client): correct base_url setter implementation #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix(client): correct base_url setter implementation #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/finch/_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ def base_url(self) -> URL:

@base_url.setter
def base_url(self, url: URL | str) -> None:
self._client.base_url = url if isinstance(url, URL) else URL(url)
self._base_url = self._enforce_trailing_slash(url if isinstance(url, URL) else URL(url))

@lru_cache(maxsize=None)
def platform_headers(self) -> Dict[str, str]:
Expand Down
20 changes: 20 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,16 @@ class Model(BaseModel):
assert isinstance(response, Model)
assert response.foo == 2

def test_base_url_setter(self) -> None:
client = Finch(
base_url="https://example.com/from_init", access_token=access_token, _strict_response_validation=True
)
assert client.base_url == "https://example.com/from_init/"

client.base_url = "https://example.com/from_setter" # type: ignore[assignment]

assert client.base_url == "https://example.com/from_setter/"

def test_base_url_env(self) -> None:
with update_env(FINCH_BASE_URL="http://localhost:5000/from/env"):
client = Finch(access_token=access_token, _strict_response_validation=True)
Expand Down Expand Up @@ -1135,6 +1145,16 @@ class Model(BaseModel):
assert isinstance(response, Model)
assert response.foo == 2

def test_base_url_setter(self) -> None:
client = AsyncFinch(
base_url="https://example.com/from_init", access_token=access_token, _strict_response_validation=True
)
assert client.base_url == "https://example.com/from_init/"

client.base_url = "https://example.com/from_setter" # type: ignore[assignment]

assert client.base_url == "https://example.com/from_setter/"

def test_base_url_env(self) -> None:
with update_env(FINCH_BASE_URL="http://localhost:5000/from/env"):
client = AsyncFinch(access_token=access_token, _strict_response_validation=True)
Expand Down