Skip to content

Adapt tests to use constants in JsonInclude.Value #5296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2025
Merged

Adapt tests to use constants in JsonInclude.Value #5296

merged 2 commits into from
Sep 9, 2025

Conversation

runeflobakk
Copy link
Contributor

Adapts a few tests to use new constants defined in FasterXML/jackson-annotations#314 (which must be merged first)

@cowtowncoder
Copy link
Member

LGTM but yes needs to wait for annotations PR merging.

@cowtowncoder cowtowncoder marked this pull request as ready for review September 9, 2025 01:05
cowtowncoder
cowtowncoder approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- good to add minor testing for new values as well.

@cowtowncoder cowtowncoder merged commit f64a10f into FasterXML:2.x Sep 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runeflobakk @cowtowncoder