Add failing tests for #5165 #5174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k163377
force-pushed
the
kotlin976-followup
branch
from
8e1bcc8 to
6f8a8c2
Compare
1 task
| .defaultSetterInfo(JsonSetter.Value.forContentNulls(Nulls.FAIL)) | ||
| .build(); | ||
|
|
||
| assertThrows( |
Member
There was a problem hiding this comment.
Instead of this, we already have @JacksonTestFailureExpected annotation, so let's use that.
And tests should be added under tofix package.
Finally, although I like modularity in many ways, in this case it'd be good to combine some if not all tests into single class, to be able to share mapper configuration (esp. since merging to 3.0 requires some work per-class)
Member
|
Thank you @k163377 ! I added a note on some changes needed, but tests themselves make sense. |
Contributor
Author
|
Sorry for leaving this for so long. |
Member
|
@k163377 no problem at all, looking forward to a new PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing tests for #5165 -- follow up to #5139 (fixed itself with #5140)