Skip to content

MV-3 #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 29, 2023
Merged

MV-3 #921

merged 12 commits into from
Mar 29, 2023

Conversation

NotAProton
Copy link
Member

@NotAProton NotAProton commented Mar 26, 2023 •
edited
Loading

tl;dr:

- "manifest_version": 2,
+ "manifest_version": 3,
  • Added eslint and prettier
  • Implemented whitelist
  • Changed how injection script and content script communicate
  • Removed preflight bypasses
  • Removed referrer cache and bypass_clipboard
  • Removed updating of bypass definitions
  • Removed custom bypasses
  • Removed Ace
  • Changed how preferences are handled
  • Made BG script compatible with manifest version 3
  • Re-wrote crowd bypass functions
  • Broke Firefox

Note: Firefox has not implemented most of the mv3 API, a backported version will have to be made

Checklist:

  • I made sure there are no unnecessary changes in the code*
  • Tested on Chromium- Chrome & Edge Windows
  • ❌ Tested on Firefox

@NotAProton
Re-write background and content scripts
a13ee2d 
Also don't remove injection scripts for any build
@github-actions
Copy link

github-actions bot commented Mar 26, 2023 •
edited
Loading

Download the artifacts for this pull request:

@0xc60f 0xc60f added the MV3 This pull request changes the MV3 source code (branch manifest-v3) label Mar 26, 2023
@NotAProton
Fix bypass imports
7bf15e5 
Also replace ace with html textarea and bump uikit
reashetyrr
reashetyrr reviewed Mar 27, 2023
View reviewed changes
reashetyrr
reashetyrr reviewed Mar 27, 2023
View reviewed changes
@NotAProton NotAProton marked this pull request as ready for review March 28, 2023 20:56
@NotAProton
remove original contet and background script files
624cbc8 
they are duplicates because git. sorry for for checking them in :/
0xc60f
0xc60f reviewed Mar 29, 2023
View reviewed changes
package.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should look into using Dependabot for the dependencies. I'll look into implementing it.

0xc60f
0xc60f requested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@0xc60f 0xc60f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of bypasssites.md, it's outdated and not used in any capacity.

@NotAProton NotAProton mentioned this pull request Mar 29, 2023
Closed
@NotAProton
Update PRIVACY.md
0a96009 
Remove auto-updating
@NotAProton NotAProton merged commit 3f5c039 into FastForwardTeam:manifest-v3 Mar 29, 2023
@lostdusty lostdusty linked an issue Apr 2, 2023 that may be closed by this pull request
SpeedForwarder (Read this) #656
Closed
6 tasks
@NotAProton NotAProton mentioned this pull request Apr 21, 2023
Merged
3 tasks
@Unknown78 Unknown78 mentioned this pull request Aug 12, 2023
Open
@NotAProton NotAProton mentioned this pull request Sep 18, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc60f 0xc60f 0xc60f approved these changes

@reashetyrr reashetyrr Awaiting requested review from reashetyrr

@undeadjess undeadjess Awaiting requested review from undeadjess

@lostdusty lostdusty Awaiting requested review from lostdusty

Assignees
No one assigned
Labels
MV3 This pull request changes the MV3 source code (branch manifest-v3)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SpeedForwarder (Read this)
3 participants
@NotAProton @reashetyrr @0xc60f