Skip to content

OIDC: Return href instead URL object #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2021
Merged

OIDC: Return href instead URL object #872

merged 1 commit into from
Jun 11, 2021

Conversation

@zcuric
Copy link
Contributor

@zcuric zcuric commented Jun 2, 2021

This PR

  • Fixes issues with OIDC which return URL object instead of string and it would fail with silent auth and other cases

@zcuric zcuric requested a review from kronicker June 2, 2021 10:35
@kronicker
Copy link
Member

kronicker commented Jun 2, 2021

@zcuric Thanks for raising PR
@underscope This should be merged ASAP since it causes issues with silent auth in production.

@underscope
Copy link
Collaborator

underscope commented Jun 10, 2021

@zcuric Base should be release/5.0

@zcuric zcuric force-pushed the fix/oidc-client-url branch from 42580d6 to e263151 Compare June 11, 2021 07:40
@zcuric zcuric changed the base branch from develop to release/5.0 June 11, 2021 07:44
@zcuric
Copy link
Contributor Author

zcuric commented Jun 11, 2021

@underscope done! 🤝

@underscope underscope merged commit 41c62a9 into release/5.0 Jun 11, 2021
@underscope underscope deleted the fix/oidc-client-url branch June 11, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kronicker kronicker kronicker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zcuric @kronicker @underscope