Change avatar border color on active state #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikovac
added
👈 needs code review
Member
|
@ikovac @underscope @MarkoLovric this seems to show the wrong (old) border color when the avatar filter is not selected/active - border color should always be the same as the background color, right? |
Contributor
Author
|
@MiroDojkic we decided to keep the old border color when the avatar is not active and only remove the old color when the avatar is active. In the second case, we are showing border color which is the same as the background color. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #840.
This PR also fixes a minor bug introduced here where the color prop is boolean instead of string.