Support default Kotlin values #981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add support for Kotlin default values. By calling functions with the
callBy
methods instead we can pass a map ofKParameters
. Then if one of the params is optional and it is not sent a value from GraphQL input we can exclude that parameter from the map, which mean the default value will be used.Kotlin
GraphQL
This info will not be conveyed in the schema, but it simplifies the logic needed for optional arguments. If you still need to have logic for the default values I recommend using the
OptionalInput
wrapper, since you will still not be able to determine the difference when the client didn't pass a value or it passed in the same value as the default.This is a breaking change because we are changing the function signature that is open for
FunctionDataFetcher
🔗 Related Issues
Fixes #53