[client] support non JSON primitive scalars #1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
added
changes: minor
dariuszkuc
force-pushed
the
client-custom-scalars
branch
from
28e2288 to
b8443c9
Compare
Collaborator
Author
|
FYI only code change is in |
Update `kotlinx-serialization` handling of custom scalars to allow non-primitive values. While custom scalars are most often represented as some primitive value (e.g. UUID -> String), there are use cases when scalars need to be represented as objects. One common use case is Apollo Federation and its usage of `_Any` scalar to represent arbitrary entity object map that contains various fields to uniquely identity it. Updated custom scalar documentation with examples n how to use arbitrary objects as custom scalars. Resolves: * ExpediaGroup#1408 * ExpediaGroup#1435 * ExpediaGroup#1445
dariuszkuc
force-pushed
the
client-custom-scalars
branch
from
b8443c9 to
4ffd659
Compare
samuelAndalon
approved these changes
Jul 26, 2022
This was referenced Jul 26, 2022
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Update `kotlinx-serialization` handling of custom scalars to allow non-primitive values. While custom scalars are most often represented as some primitive value (e.g. UUID -> String), there are use cases when scalars need to be represented as objects. One common use case is Apollo Federation and its usage of `_Any` scalar to represent arbitrary entity object map that contains various fields to uniquely identity it. Updated custom scalar documentation with examples n how to use arbitrary objects as custom scalars. Resolves: * ExpediaGroup#1408 * ExpediaGroup#1435 * ExpediaGroup#1445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Update
kotlinx-serializationhandling of custom scalars to allow non-primitive values. While custom scalars are most often represented as some primitive value (e.g. UUID -> String), there are use cases when scalars need to be represented as objects. One common use case is Apollo Federation and its usage of_Anyscalar to represent arbitrary entity object map that contains various fields to uniquely identity it.Updated custom scalar documentation with examples n how to use arbitrary objects as custom scalars.
🔗 Related Issues
Resolves: