Update spring-server to use FlowSubscriptionSchemaGeneratorHooks #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `spring-server` automatically configures the subscription strategy that supports Kotlin `Flow` but does not configure the hooks neccessary to use it. Updating `SubscriptionAutoConfiguration` to create `FlowSubscriptionSchemaGeneratorHooks` if bean is not available. Cleaned up the federation docs to highlight that both hooks and execution strategy are needed for using `Flow`s in subscriptions. Added a note that the subscription protocol implemented in `spring-server` is deprecated.
dariuszkuc
added
changes: minor
samuelAndalon
approved these changes
Jun 27, 2022
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…ediaGroup#1479) Currently the `spring-server` automatically configures the subscription strategy that supports Kotlin `Flow` but does not configure the hooks neccessary to use it. Updating `SubscriptionAutoConfiguration` to create `FlowSubscriptionSchemaGeneratorHooks` if bean is not available. Cleaned up the federation docs to highlight that both hooks and execution strategy are needed for using `Flow`s in subscriptions. Added a note that the subscription protocol implemented in `spring-server` is deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Currently the
spring-serverautomatically configures the subscription strategy that supports KotlinFlowbut does not configure the hooks neccessary to use it. UpdatingSubscriptionAutoConfigurationto createFlowSubscriptionSchemaGeneratorHooksif bean is not available.Cleaned up the federation docs to highlight that both hooks and execution strategy are needed for using
Flows in subscriptions. Added a note that the subscription protocol implemented inspring-serveris deprecated.🔗 Related Issues
#1477