fix passing doc string as format parameter #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes ExpediaGroup#1023 The kotlin poet api takes as first argument a format parameter for `addKdoc()`. So comments with percent signs would cause the format argument parser to error.
dariuszkuc
reviewed
Jan 22, 2021
|
|
||
| val unkownTypeSpec = TypeSpec.anonymousClassBuilder() | ||
| .addKdoc("This is a default enum value that will be used when attempting to deserialize unknown value.") | ||
| .addKdoc("%L", "This is a default enum value that will be used when attempting to deserialize unknown value.") |
There was a problem hiding this comment.
since the passed in text is a constant without any special chars we technically don't need the extra formatting here
There was a problem hiding this comment.
Fair enough. I figured the consistency was more important.
dariuszkuc
approved these changes
Jan 22, 2021
dariuszkuc
added
changes: patch
huehnerlady
pushed a commit
to huehnerlady/graphql-kotlin
that referenced
this pull request
Apr 27, 2021
closes ExpediaGroup#1023 The kotlin poet api takes as first argument a format parameter for `addKdoc()`. So comments with percent signs would cause the format argument parser to error.
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
closes ExpediaGroup#1023 The kotlin poet api takes as first argument a format parameter for `addKdoc()`. So comments with percent signs would cause the format argument parser to error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The kotlin poet api takes as first argument a format parameter for
addKdoc().So comments with percent signs would cause the format argument parser to error.
🔗 Related Issues
Resolves: #1023