-
Notifications
You must be signed in to change notification settings - Fork 0
V2 #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ChALkeR
wants to merge
16
commits into
master
Choose a base branch
from
v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ChALkeR there are some conflicts here |
@mvayngrib Let's call this not a v2 but a separate lib perhaps. |
gutenye
reviewed
Oct 7, 2025
return res.json() | ||
} | ||
|
||
const err = new Error(res.statusText) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const err = new Error(res.statusText) | |
const err = new Error(`${res.status} ${res.statusText || ''}`.trim()) |
Fix the statusText is undefined case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.7.0,
@exodus/fetch
already just prefers to use globalfetch
andWebSocket
Which covers all platforms we need
Instead of doing gradual changes and optimizing out code, let's just remove everything we don't use/need and call this a v2
fetchival
is replaced withexperimental/fetchival
and is renamed tofetcher
to avoid confusion, as the API differsCompared to
fetchival
, new API is hardened to prevent unescaped injection of url components (previously was available asexperimental/fetchival
)Compared to
experimental/fetchival
, the non-standardtimeout
option default value is removed (reverted tofetchival
behavior)Also switched to ESM and
@exodus/test
Also 0-dep now
This is a somewhat work in progress, I might improve this further