Skip to content

Fail on missing semicolons #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fail on missing semicolons #1346

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
785fe81
Initial commit, doesn't build yet
LadyCailin Jun 10, 2022
0c8d846
Merge remote-tracking branch 'origin/master' into failOnMissingSemico…
LadyCailin Jan 11, 2023
39435eb
Remove critical path for now, so merge can happen
LadyCailin Jan 11, 2023
3aa9c60
Merge remote-tracking branch 'origin/master' into failOnMissingSemico…
LadyCailin Jan 11, 2023
72b17d1
Re-add tests
LadyCailin Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/test/java/com/laytonsmith/core/OptimizationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ private void testSemicolonUsage(String script, boolean passExpected) throws Exce
}
}

// @Test
@Test
public void testMissingSemicolonWarnsInStrictMode() throws Exception {
testSemicolonUsage("<! strict > if(dyn(true)) { if(dyn(true)) {} if(dyn(true)) {} }", true);
testSemicolonUsage("<! strict > if(dyn(true)) { } else if(dyn(1) == 1) { }", true);
Expand All @@ -806,7 +806,7 @@ public void testMissingSemicolonWarnsInStrictMode() throws Exception {
testSemicolonUsage("<! strict > if(dyn(true)) {} array()", false);
}

// @Test
@Test
public void testConstantIsntStatement() throws Exception {
try {
optimize("'string';");
Expand Down