`overwrite` parameter doesn't behave as expected

[tsmbland]

This parameter is used on a per-output basis to control whether the program will overwrite existing files. See here

If you set this as false then the program will refuse to overwrite existing files and will abort, as expected. However, if this parameter is not specified, then it appears to default to true (i.e. overwriting existing files), despite what the documentation says. Not sure what's going on though, because this line looks like it's taking False as the default:

MUSE_OS/src/muse/outputs/sinks.py

Line 120 in 48095f6

overwrite = params.pop("overwrite", False)

So clearly something is broken somewhere.

In any case, it seems strange to have this setting on a per-output basis. I think it would make much more sense as a global setting (i.e. if false, no files will be overwritten)

Update: Actually, the documentation does say that the overwrite parameter only applies to the "csv" sink (not the "aggregate" sink), which I missed before. Still, I'm leaving this issue up as I still think things could be improved here.