-
Notifications
You must be signed in to change notification settings - Fork 242
Feature/winsock2 support #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9da190f to
9ef2a6b
Compare
5187cb9 to
79288f1
Compare
Signed-off-by: Dusan Cervenka <[email protected]>
|
Hi @thewon86 , i was trying to add tests builds for mingw with your tcp layer. I had to do some changes also in source files due to errors. Can you confirm that these changes works for you? |
|
@MichalPrincNXP Could you also review these changes? I added mingw tcp tests support so we see that server client may communicate. |
Remove redundant print cmd
Signed-off-by: Cervenka Dusan <[email protected]>
Looks like server on mac target is not ready when client is executed Signed-off-by: Cervenka Dusan <[email protected]>
and it works well |
Signed-off-by: Cervenka Dusan <[email protected]>
|
Hi @thewon86 could you try it with last commit? Also i don't understand why you posted errors with test_const. Build for mingw looks passing this test and you are mentioning only issue with g_client. |
The issue with g_client has been solved.
Is that because all and They all be declared weak & extern |
|
Hi @thewon86 , unfortunatelly for mingw currently "make clean" doesn't work. Could you remove generated folders under each test and then press "make all" generate code again? You shouldn't see these errors then. |
|
Hi @Hadatko , it works, everything done well. |
|
@MichalPrincNXP any comments to this PR? |
MichalPrincNXP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, thank you
Pull request
Choose Correct
Describe the pull request
Is ERPC support Windows platform? #299
To Reproduce
Expected behavior
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context