Skip to content

Conversation

@Hadatko
Copy link
Member

@Hadatko Hadatko commented Jan 26, 2023

Signed-off-by: Cervenka Dusan [email protected]

Pull request

Choose Correct

  • [] bug
  • feature

Describe the pull request

Replacing sprintf with snprintf -> safety

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

Additional context

@Hadatko Hadatko self-assigned this Jan 26, 2023
@Hadatko
Copy link
Member Author

Hadatko commented Jan 26, 2023

This PR partially solve issue here: #342
Also change in erpc_sysgpio are not tested, and it these files are taken from somewhere it could be fine to contact owner and apply fix.

@Hadatko Hadatko modified the milestone: 1.11.0 Jan 26, 2023
Signed-off-by: Cervenka Dusan <[email protected]>
@Hadatko Hadatko force-pushed the bugfix/replace_sprintf branch from d01c05f to 87d4bec Compare January 26, 2023 00:11
@MichalPrincNXP
Copy link
Member

This PR partially solve issue here: #342 Also change in erpc_sysgpio are not tested, and it these files are taken from somewhere it could be fine to contact owner and apply fix.

OK, will do that

@MichalPrincNXP
Copy link
Member

This PR partially solve issue here: #342 Also change in erpc_sysgpio are not tested, and it these files are taken from somewhere it could be fine to contact owner and apply fix.

OK, will do that

erpc_sysgpio author is OK with proposed changes

@Hadatko
Copy link
Member Author

Hadatko commented Jan 30, 2023

great

@MichalPrincNXP MichalPrincNXP merged commit 35e6d25 into EmbeddedRPC:develop Jan 30, 2023
@MichalPrincNXP
Copy link
Member

thank you

@Hadatko Hadatko deleted the bugfix/replace_sprintf branch January 30, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants