Fix Python template bugs on union discriminator and reference #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Python codec template bugs related to unions. Both encoder and decoder were emitting a literal 'discriminator' instead of de-referencing this data structure member for the actual discriminator symbol name. In class method template, use object scope instead of global scope to invoke the write() method of a non-encapsulated union member.
MichalPrincNXP
approved these changes
Sep 14, 2020
|
Thank you, @RamseyTI ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Python codec template bugs related to unions. Both encoder
and decoder were emitting a literal 'discriminator' instead
of de-referencing this data structure member for the actual
discriminator symbol name. In class method template, use object
scope instead of global scope to invoke the write() method of
a non-encapsulated union member.