Skip to content

[BUG] Cursor class is inside message buffer class  #281

@amgross

Description

@amgross

Describe the bug

1Cursor class is in side message buffer class, although the message buffer don't use its inner cursor and the cursor is using message buffer that it gets as input instead its own message buffer. It makes things unclear and other bugs (In other issues I will open)

To Reproduce

Expected behavior

there are three options (from better to worth in my opinion):

  1. instead of cursor class, to have in the message buffer variable of m_cursor_pos (That is what I suggesting)
  2. Have the cursor class be separated
  3. Cursor class will use the message class it is inside of.

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:v1.9.0

Steps you didn't forgot to do

  • I checked if there is no related issue opened/closed.
  • I checked that there doesn't exist opened PR which is solving this issue.

Additional context

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions