Many minor code improvements. (#323)

* Many minor code improvements.

Signed-off-by: Cervenka Dusan <[email protected]>

* Fix based on PR

Signed-off-by: Cervenka Dusan <[email protected]>

---------

Signed-off-by: Cervenka Dusan <[email protected]>

Author: Hadatko

erpc_c/infra/erpc_arbitrated_client_manager.hpp

@@ -76,7 +76,7 @@ class ArbitratedClientManager : public ClientManager
      *
      * @param[in] request Request context to perform.
      */
-    virtual void performClientRequest(RequestContext &request);
+    virtual void performClientRequest(RequestContext &request) override;
 
     //! @brief This method is not used with this class.
     void setTransport(Transport *transport) { (void)transport; }

erpc_c/infra/erpc_client_server_common.hpp

@@ -32,7 +32,7 @@
 namespace erpc {
 
 /*!
- * @brief Common class inheritand by client and server class.
+ * @brief Common class inherited by client and server class.
  *
  * @ingroup infra_utility
  */

erpc_c/infra/erpc_crc16.hpp

@@ -34,7 +34,7 @@ class Crc16
      *
      * @param[in] crcStart Start value for crc function.
      */
-    Crc16(uint32_t crcStart);
+    explicit Crc16(uint32_t crcStart);
 
     /*!
      * @brief Constructor.

erpc_c/infra/erpc_message_loggers.hpp

@@ -34,7 +34,7 @@ class MessageLogger
     /*!
      * @brief MessageLogger constructor.
      */
-    MessageLogger(Transport *transport)
+    explicit MessageLogger(Transport *transport)
     : m_next(NULL)
     , m_transport(transport){};
 

erpc_c/infra/erpc_static_queue.hpp

@@ -42,6 +42,7 @@ class StaticQueue
         m_capacity = elementCount;
         m_head = 0;
         m_tail = 0;
+        (void)memset(m_storage, 0, sizeof(m_storage));
     }
 
     /*!
@@ -106,9 +107,9 @@ class StaticQueue
     uint64_t m_storage[elementCount]
                       [(sizeof(T) + sizeof(uint64_t) - 1U) / sizeof(uint64_t)]; /*!< Preallocated space based on data
                                                                                   type size and elements count. */
-    uint32_t m_capacity;                                                       /*!< Capacity of queue */
-    uint32_t volatile m_head;                                                  /*!< Index to free slot */
-    uint32_t volatile m_tail;                                                  /*!< Index to slot with m_data */
+    uint32_t m_capacity;                                                        /*!< Capacity of queue */
+    uint32_t volatile m_head;                                                   /*!< Index to free slot */
+    uint32_t volatile m_tail;                                                   /*!< Index to slot with m_data */
 };
 
 } // namespace erpc

erpc_c/port/erpc_serial.cpp

@@ -171,7 +171,7 @@ int serial_set_read_timeout(int fd, uint8_t vtime, uint8_t vmin)
     return 0;
 }
 
-int serial_write(int fd, char *buf, int size)
+int serial_write(int fd, const char *buf, int size)
 {
 #ifdef _WIN32
     HANDLE hCom = (HANDLE)fd;
@@ -207,7 +207,6 @@ int serial_read(int fd, char *buf, int size)
 {
 #ifdef _WIN32
     HANDLE hCom = (HANDLE)fd;
-    unsigned long bread = 0;
     char temp[RX_BUF_BYTES] = { 0 };
     DWORD errors;
     DWORD bytesToRead = 0;
@@ -262,7 +261,7 @@ int serial_read(int fd, char *buf, int size)
     return bytesToRead;
 #else
     int len = 0;
-    int ret = 0;
+    int ret;
     int timeout = 0;
 
     while (len < size)

erpc_c/port/erpc_serial.h

@@ -64,7 +64,7 @@ extern "C" {
 
 int serial_setup(int fd, speed_t speed);
 int serial_set_read_timeout(int fd, uint8_t vtime, uint8_t vmin);
-int serial_write(int fd, char *buf, int size);
+int serial_write(int fd, const char *buf, int size);
 int serial_read(int fd, char *buf, int size);
 int serial_open(const char *port);
 int serial_close(int fd);

erpc_c/port/erpc_spidev.cpp

@@ -69,7 +69,7 @@ int spidev_set_wordbits(int fd, unsigned char bits)
     return retVal;
 }
 
-int spidev_transfer(int fd, unsigned char *tx_buf, unsigned char *rx_buf, unsigned int len)
+int spidev_transfer(int fd, const unsigned char *tx_buf, unsigned char *rx_buf, unsigned int len)
 {
     int retVal = ERPC_SPIDEV_STATUS_SUCCESS;
     struct spi_ioc_transfer spi_message;

erpc_c/port/erpc_spidev.h

@@ -20,7 +20,7 @@ int spidev_open(const char *port);
 int spidev_set_mode(int fd, unsigned char mode);
 int spidev_set_speed(int fd, unsigned int speed_hz);
 int spidev_set_wordbits(int fd, unsigned char bits);
-int spidev_transfer(int fd, unsigned char *tx_buf, unsigned char *rx_buf, unsigned int len);
+int spidev_transfer(int fd, const unsigned char *tx_buf, unsigned char *rx_buf, unsigned int len);
 int spidev_close(int fd);
 
 #if __cplusplus

erpc_c/setup/erpc_setup_dspi_master.cpp

@@ -25,7 +25,7 @@ ERPC_MANUALLY_CONSTRUCTED(DspiMasterTransport, s_transport);
 
 erpc_transport_t erpc_transport_dspi_master_init(void *baseAddr, uint32_t baudRate, uint32_t srcClock_Hz)
 {
-    s_transport.construct((SPI_Type *)baseAddr, baudRate, srcClock_Hz);
+    s_transport.construct(reinterpret_cast<SPI_Type *>(baseAddr), baudRate, srcClock_Hz);
     (void)s_transport->init();
     return reinterpret_cast<erpc_transport_t>(s_transport.get());
 }