Many minor code improvements. #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@MichalPrincNXP i think this one can be merged. But it needs run as many tests/apps as we have. |
Member
|
I have started testing locally, erpcgen builds seems to be ok, there are several build issues, see my two comments. Could you please rebase to the develop branch head? |
Signed-off-by: Cervenka Dusan <[email protected]>
Signed-off-by: Cervenka Dusan <[email protected]>
Hadatko
force-pushed
the
feature/declarations
branch
from
23ded4a to
f5b586a
Compare
Member
Author
|
I made changes based on your notes. Good eyes. Thank you ;) |
Member
|
Thank you for the update and rebase, I will continue with on-board testing. |
MichalPrincNXP
approved these changes
Mar 10, 2023
Member
MichalPrincNXP
left a comment
MichalPrincNXP
left a comment
There was a problem hiding this comment.
All build and on-board tests passed.
Member
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cervenka Dusan [email protected]
Pull request
Choose Correct
Describe the pull request
Minor changes to type definitions and casts. This can lower memory/cpu usage a bit for generating shim code.
To Reproduce
Expected behavior
tests pass
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context