transaction: range-check pegin data when parsing #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI failure is an unrelated thing; I have another branch I'm working on to fix clippy and update things but I'm seeing a weird bug with clippy. |
delta1
approved these changes
Jun 19, 2024
Merged
apoelstra
added a commit
that referenced
this pull request
Jun 20, 2024
8d58ec3 clippy: use u32::MAX rather than u32::max_value (Andrew Poelstra) 172e36b clippy: fix indentation in documentation (Andrew Poelstra) 4ab1b77 blech32: delete unconstructable iterator struct (Andrew Poelstra) a89ff6e fix a couple feature gates (Andrew Poelstra) Pull request description: Do some cleanups and get CI working again. Will rebase #203 on this. ACKs for top commit: delta1: ACK 8d58ec3 Tree-SHA512: 62ca188d031e71e39279b7407cef746ea4bec2c72baad633603fd67834efa6774027b060d20fddbb9bfff609b676b1b6d2f20a1c663e7fea207a3b08772e3e0c
It is possible to cause a panic by calling `TxIn::pegin_data` on a malformed pegin, which has 6 entries and the last one (which should be a Merkle proof of block inclusion) is too small to even have a blockhash in it. On the actual chain this should not be possible because invalid pegin data would be rejected.
apoelstra
force-pushed
the
2024-06--pegin-parse
branch
from
f86e219 to
639c964
Compare
Member
Author
|
Rebased. Ready for re-review. |
Member
|
reACK 639c964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to cause a panic by calling
TxIn::pegin_dataon a malformed pegin, which has 6 entries and the last one (which should be a Merkle proof of block inclusion) is too small to even have a blockhash in it.On the actual chain this should not be possible because invalid pegin data would be rejected.