parameterize the mandatory coinbase #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
force-pushed
the
mandatorycbase
branch
from
c808884 to
d77df82
Compare
jtimon
reviewed
Apr 2, 2018
| REJECT_INVALID, "bad-coinbase-txos"); | ||
| if (chainparams.GetConsensus().mandatory_coinbase_destination != CScript()) { | ||
| BOOST_FOREACH(const CTxOut& txout, block.vtx[0]->vout) { | ||
| if (txout.scriptPubKey != chainparams.GetConsensus().mandatory_coinbase_destination && !(txout.nValue.IsExplicit() && txout.nValue.GetAmount() == 0)) |
Contributor
There was a problem hiding this comment.
Mhmm, so if outputs are confidential or 0 it is allowed that they're sent anywhere? why?
Also shouldn't we validate that all coinbase outputs are explicit regardless of mandatory_coinbase_destination?
Contributor
Author
There was a problem hiding this comment.
By consensus they can't be confidential(the check is later in VerifyCoinbaseAnounts), and you need to allow 0-value outputs for commitments, such as segwit.
Contributor
|
utACK beyond nits. |
instagibbs
added a commit
that referenced
this pull request
Apr 3, 2018
d77df82 parameterize the mandatory coinbase (Gregory Sanders)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #328