Skip to content

Conversation

@instagibbs
Copy link
Contributor

No description provided.

@jtimon
Copy link
Contributor

jtimon commented Mar 28, 2018

Perhaps move the documentation for "-bitcoinconfirmationdepth" from init.cpp to https://github.com/ElementsProject/elements/blob/elements-0.14.1/src/chainparamsbase.cpp#L24 ? (oops, just noticed the -chainpetname argument isn't used anymore since its taken directly from -chain).

Bikeshed: perhaps pegin_min_depth or pegin_depth ?

Bikeshed: perhaps change -bitcoinconfirmationdepth to -con_min_depth (or -con_whateverthefinalname) for consistency?

Besides nits, utACK

@instagibbs
Copy link
Contributor Author

rebased, addressed the variable naming concern. It may be something we want to tweak in the future even on a production system, so not sure we should name it -con_*. It's almost not consensus, in the sense we can set it depending on how we feel about the parent chain's stability.

@instagibbs instagibbs merged commit b628d91 into ElementsProject:elements-0.14.1 Mar 28, 2018
instagibbs added a commit that referenced this pull request Mar 28, 2018
b628d91 make peginconfirmationdepth a chain param (Gregory Sanders)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants