add peg test for bitcoind temporarily being down during peg validation #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtimon
reviewed
Mar 23, 2018
qa/rpc-tests/pegging.py
Outdated
Contributor
There was a problem hiding this comment.
Perhaps call sync_all(sidechain, sidechain2) here and before the next assert?
Contributor
Author
There was a problem hiding this comment.
not here, since they don't sync, but yes subsequent makes sense!
Contributor
Author
There was a problem hiding this comment.
actually no.... we are waiting for bitcoind to be up. We could spin-wait trying to connect at least.
Contributor
Author
There was a problem hiding this comment.
3rd thoght, you're right, will fix
instagibbs
force-pushed
the
timeoutpegtest
branch
from
e357d66 to
030035e
Compare
Contributor
Author
|
@jtimon pushed fix |
instagibbs
force-pushed
the
timeoutpegtest
branch
from
030035e to
f62c2d5
Compare
Contributor
Author
|
pushed real fix, with explanation inline in test. It was hitting some corner cases with pegin validity and block making |
jtimon
added a commit
that referenced
this pull request
Apr 2, 2018
…eg validation f62c2d5 add peg test for bitcoind temporarily being down during peg validation (Gregory Sanders)
Contributor
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests that blocks are only temporarily rejected, and recovery happens once connection is restored