Fix ASP.NET backend listening on 0.0.0.0 #266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
Default behavior for windows appears to be to resolve
localhost
to0.0.0.0
which causes the Windows firewall to get triggered, but also exposes the ASP.NET backend to remote access which opens up the app to RCE risks unnecessarily.Also
Add a comment for why NodeIntegration is true.
The version used in the build script is now a variable, only needs to be changed once.
I've validated that with this changed behavior, our App, Attack Surface Analyzer, encounters no issues. I'm unable to test it on the WebApp as the version on master currently does not work for me (even without my changes).