Skip to content

Upgrade haskell.haskell to 1.2.0 #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Conversation

djcrock
Copy link
Contributor

@djcrock djcrock commented Nov 7, 2020

@spoenemann
Copy link
Collaborator

The haskell namespace has been claimed:
EclipseFdn/open-vsx.org#115

But the extension is still published by our script:
ceccded

@jankeromnes do you remember why it is like that? @jaspervdj would you like to publish the extension yourself?

The extension is currently displayed with a warning because it has an owner, but is still published by our service account:
https://open-vsx.org/extension/haskell/haskell

@jankeromnes
Copy link
Collaborator

The haskell namespace has been claimed:
EclipseFdn/open-vsx.org#115

But the extension is still published by our script:
ceccded

@jankeromnes do you remember why it is like that?

Yes. This extension was added to our auto-publish list the day before the namespace was claimed:

Screenshot 2020-11-10 at 09 44 42

Screenshot 2020-11-10 at 09 44 58

@jaspervdj Please publish haskell.haskell 1.2.0 to OpenVSX (e.g. you can do so simply by running npx ovsx publish)

@spoenemann
Copy link
Collaborator

Ok, we should remove the entry from here, then.

@jankeromnes
Copy link
Collaborator

See also haskell/vscode-haskell#250 (comment)

@jankeromnes
Copy link
Collaborator

Seems like OpenVSX-publishing was already set up for haskell.haskell by @bubba.

But it was disabled again in haskell/vscode-haskell@93e7b58 due to a missing OPEN_VSX_ACCESS_TOKEN token in Travis CI: haskell/vscode-haskell#250 (comment)

Copy link
Collaborator

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is no harm in simply bumping our auto-published version while @jaspervdj and @bubba decide whether they want to take over the OpenVSX publishing.

@jankeromnes jankeromnes merged commit 2bf6fb2 into EclipseFdn:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants