Skip to content

Publish on open-vsx.org / VSCodium support #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkoloberdin opened this issue Jul 26, 2020 · 15 comments · Fixed by #369
Closed

Publish on open-vsx.org / VSCodium support #250

mkoloberdin opened this issue Jul 26, 2020 · 15 comments · Fixed by #369

Comments

@mkoloberdin
Copy link

Could you please publish the extension on open-vsx.org as well?
See https://github.com/VSCodium/vscodium/blob/master/DOCS.md#extensions-marketplace

@lukel97
Copy link
Collaborator

lukel97 commented Aug 11, 2020

Hi @jaspervdj, could you log into https://open-vsx.org from the haskell GitHub org and create an access token for this? https://github.com/eclipse/openvsx/wiki/Publishing-Extensions#1-create-an-access-token

@jaspervdj
Copy link
Member

@bubba I tried, but it seems that I can only get an access token for my personal account (jaspervdj) and not the Org. I think what we should do is first have you create the haskell namespace, and after that I should be able to claim it using this procedure and grant everyone who needs it access.

@lukel97
Copy link
Collaborator

lukel97 commented Aug 11, 2020

@jaspervdj just created an access token and went to create the namespace, but apparently it already exists:

$ npx ovsx create-namespace haskell -p ...
npx: installed 68 in 4.862s
❌  Namespace already exists: haskell

So can we just skip this step and go directly to claiming it? https://github.com/eclipse/open-vsx.org/issues/new/choose

@jaspervdj
Copy link
Member

@bubba That worked! I've added you to the haskell namespace. Hopefully that'll allow you to publish this extension.

@lukel97
Copy link
Collaborator

lukel97 commented Aug 11, 2020

Looks like we can't upload it just yet as the syntax highlighting dependency isn't on open-vsx.org yet, created an issue to track this: JustusAdam/language-haskell#171

@lukel97
Copy link
Collaborator

lukel97 commented Aug 19, 2020

Apparently open-vsx has already published it on our behalf this week: EclipseFdn/publish-extensions@ceccded

We should still setup travis ci to also publish to open-vsx.org on each tag

@lukel97
Copy link
Collaborator

lukel97 commented Aug 19, 2020

eclipse/openvsx#159

@lukel97
Copy link
Collaborator

lukel97 commented Aug 19, 2020

@jaspervdj I thought I used to able to access the settings page of the travis CI for this repo, but looks like I no longer have access. On https://travis-ci.org/github/haskell/vscode-haskell can you add a new secret for your access token/any access token that is in the Haskell namespace? Under the key OPEN_VSX_ACCESS_TOKEN so that 2b078fa can pick it up

@jneira
Copy link
Member

jneira commented Sep 29, 2020

Afaik @fendor already is using the extension in vscodium

@fendor
Copy link
Collaborator

fendor commented Sep 29, 2020

Yes, I am! Works marvelously!

codium

@jneira jneira closed this as completed Sep 29, 2020
@jneira
Copy link
Member

jneira commented Sep 29, 2020

Ops, @bubba maybe we still should add the publishing in ci

@jneira jneira reopened this Sep 29, 2020
@lukel97
Copy link
Collaborator

lukel97 commented Oct 11, 2020

@jneira I commented out the publishing step just there, I think we need someone from the haskell org to add the OPEN_VSX_ACCESS_TOKEN key to travis ci first

@jneira
Copy link
Member

jneira commented Mar 16, 2021

@jaspervdj could we add the secret key to activate the publishing? thanks!

@jaspervdj
Copy link
Member

@bubba @jneira Sorry, I completely forgot about this. I added a secret for OPEN_VSX_ACCESS_TOKEN in Travis. I restricted it to the master branch. Give it a try and let me know if I need to change anything?

@jneira
Copy link
Member

jneira commented Mar 16, 2021

many thanks and no worries, sure you are very very busy 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants