Issue 316 -- updated code to account for httpOnly and Secure cookie … #393
Conversation
|
@kwwall my apologies... github doesn't work like gerritt: looks like this single pull request will also include the changes I just made for the search directory issue. I still need to write a series of unit tests to ensure that if those directory paths get changed again in the future, it'll cause the build to fail. |
|
@xeno6696 No worries. Regarding the JUnit tests, it wouldn't surprise me if we have any tests at all trying to load ESAPI.properties from all the legal places so it's not surprising that we missed this the last time. But if you can think of an easy way to test this via JUnit, then go for it. I did look at the most recent code change though and it looks spot on. -kevin |
…gacy javadoc comments.
|
@kwwall you're falling behind on reviewing all the commits here... |
…lso updated the unit test to use non-deprecated asserts.
…adequately updated in the future, and upped JVM compliance level to 1.7 since we already decided that 1.6 is more than defunct.
|
@jeremiahjstacey I could use your code review expertise here. I haven't committed professional code in awhile, want to make sure I'm not stupid. |
xeno6696
changed the title
|
Per our conversation yesterday @kwwall I'm going to merge these changes in. The last commits from yesterday created an Enum for the path search locations and added unit tests for when items in the enum get added/deleted and ensures that if those values ever change and the test isn't updated it'll break the build. |
3 participants
@kwwall -- I can't seem to find where the "deprecated" httpOnly exists from my original comment in #316