Skip to content

Fix a bug in the media query provider #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix a bug in the media query provider #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1394ae4
Fix a bug in the media query provider
gwn Sep 21, 2019
95397e8
Fix a code styling error in media query provider
gwn Sep 21, 2019
17fa96c
Update dist after latest changes
gwn Sep 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dist/media-query-provider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ var MediaQueryProvider = function (_React$Component) {

// need to rerender with correct media if it didnt match up with initial
if (!(0, _shallowequal2.default)(media, this.state.media)) {
this.currentMediaState = media;
this.setState({ media: media }); // eslint-disable-line react/no-did-mount-set-state
}
}
Expand Down
1 change: 1 addition & 0 deletions src/media-query-provider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ class MediaQueryProvider extends React.Component {

// need to rerender with correct media if it didnt match up with initial
if (!shallowequal(media, this.state.media)) {
this.currentMediaState = media;
this.setState({ media }); // eslint-disable-line react/no-did-mount-set-state
}
}
Expand Down