(Breaking) Wrap weight and priority in an options object #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After thinking about it, I'd rather overload the affected methods to allow both signatures and annotate the old signature as deprecated. This could be released immediately, and we can remove the old signature in a 0.6.0 (or maybe even 1.0.0, I think eight years are long enough for a major release 😏 ). |
dmurvihill
commented
Mar 7, 2025
| semaphore.acquire({ weight: 1, priority: 5 }) // Equivalent | ||
|
|
||
| semaphore.acquire(2) // Old | ||
| semaphore.acquire({ weight: 5 }) // New |
There was a problem hiding this comment.
Oops, that's not the same weight!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider merging this next time you choose to publish breaking changes. It wraps the
weightandpriorityoptions into a single object, preserving the same default values as before.Users who do not pass the
weightorpriorityarguments should be unaffected.